-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Go Modules #25
Conversation
Sorry that we hadn't removed the |
Sure thing, as soon as your PR is merged I'll remove everything from this PR except the validation script fix, and then after that's merged I can update the |
Done, PTAL. |
This was the previous method used in some PRs and we suggested adding here #26 |
Adding tidy sounds good, but we probably don't want to check the value of GO111MODULE because "on" will be the default value when Go 1.14 is released and if it's defaulting to on it still won't show up in EDIT: Added |
Signed-off-by: Sam Whited <sam@samwhited.com>
This method seems to make sense to me, and helps have an easy "switch" for transition--when the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I thought we would have a transition period where we still use If we don't have the transition period, we can just use either |
A transition period seems like you'd just wind up with the vendor.conf and go.mod being out of sync somehow, then when you switch over fully to go.mod you accidentally downgrade a dependency. You would possibly also want to add a test that always checked that they were in sync on each PR to make sure this didn't happen by mistake. This seems like a lot of work to me instead of just upgrading repo-by-repo to go.mod. |
Sure, let's try this approach, it seems very reasonable and requires no extra configuration from the caller. LGTM |
Attempting to support modules for containerd projects. Specifically this PR adds a
go.mod
file for this repo and updates the vendor validation script to support go modules alongsidevndr
by checking for the presence ofvendor.conf
and usingvndr
if it exists orgo mod vendor
if it does not.