[Refactor] refactor image save flagging process #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyanhanx
force-pushed
the
refactor-image-save-flag
branch
from
e956022
to
ec9107a
Compare
djdongjin
reviewed
Jan 25, 2023
suyanhanx
force-pushed
the
refactor-image-save-flag
branch
from
ec9107a
to
57c05ec
Compare
djdongjin
reviewed
Jan 26, 2023
Comment on lines
+36
to
+46
| if options.Output != "" { | ||
| f, err := os.OpenFile(options.Output, os.O_CREATE|os.O_WRONLY, 0644) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer f.Close() | ||
| options.Stdout = f | ||
| } else { | ||
| if isatty.IsTerminal(os.Stdout.Fd()) { | ||
| return fmt.Errorf("cowardly refusing to save to a terminal. Use the -o flag or redirect") | ||
| } | ||
| } |
There was a problem hiding this comment.
(below is more for discussion and see other reviewers' thought).
I think we should remove Output string from ImageSaveOptions. Functionally, it represents the same thing as Stdout io.Writer and having both might cause inconsistency and confusing, for example:
- Even
Output != "", we initStdout = cmd.OutOrStdout()when creatingImageSaveOptions, and then change it after the file writer created (i.e., here). - Should a caller specify
Output, orStdout io.Writer?
If we remove Output and keep Stdout only:
pkg/cmdside logic doesn't need to know where the writer comes from. It just writes content to it.- On
cmdside, we initopt.Stdout = cmd.OutOrStdout()ifoutput == ""or create a file writer and use it asopt.Stdout(i.e., this pard of code).
There was a problem hiding this comment.
I think your thought is a pretty good idea. I will keep the code quo for now.
There was a problem hiding this comment.
PTAL. Thanks. @AkihiroSuda @Zheaoli
There was a problem hiding this comment.
I think it's better to make another PR to simplify the logic. I prefer to keep the same code here (one PR for one thing). BTW I have made a new issue to discuss this
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
suyanhanx
force-pushed
the
refactor-image-save-flag
branch
from
57c05ec
to
aee0d8a
Compare
djdongjin
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1680
Checklist:
pkg/api/types/${cmd}_types.go, and define the CommandOption for this commandpkg/cmd/${cmd}, and move the command entry point in real into this packageSigned-off-by: suyanhanx suyanhanx@gmail.com