Fix the top command on Windows #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dardelean
force-pushed
the
feature/hyperv-containers
branch
from
a7a9f4a
to
dabd12a
Compare
aznashwan
reviewed
Feb 21, 2023
dardelean
force-pushed
the
feature/hyperv-containers
branch
from
dabd12a
to
2eaa39f
Compare
|
CI failing |
dardelean
force-pushed
the
feature/hyperv-containers
branch
from
2eaa39f
to
e450891
Compare
AkihiroSuda
reviewed
Feb 28, 2023
dardelean
force-pushed
the
feature/hyperv-containers
branch
from
e450891
to
a945e3e
Compare
dcantah
reviewed
Mar 1, 2023
dcantah
approved these changes
Mar 1, 2023
dcantah
reviewed
Mar 1, 2023
Comment on lines
+38
to
+51
| hypervServiceName := "vmms" | ||
|
|
||
| m, err := mgr.Connect() | ||
| if err != nil { | ||
| t.Fatalf("unable to access Windows service control manager: %s", err) | ||
| } | ||
| defer m.Disconnect() | ||
|
|
||
| s, err := m.OpenService(hypervServiceName) | ||
| // hyperv service is not present, hyperv is not enabled | ||
| if err != nil { | ||
| t.Skip("HyperV is not enabled, skipping test") | ||
| } | ||
| defer s.Close() |
There was a problem hiding this comment.
I'm adding a little helper we can use for future hyperv tests here #2062
dardelean
force-pushed
the
feature/hyperv-containers
branch
from
a945e3e
to
e26cfb1
Compare
dardelean
force-pushed
the
feature/hyperv-containers
branch
4 times, most recently
from
ad5440b
to
c7a803d
Compare
Signed-off-by: Dan Ardelean <dardelean@cloudbasesolutions.com>
dardelean
force-pushed
the
feature/hyperv-containers
branch
from
c7a803d
to
ade009b
Compare
|
Ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top command did not work for Windows before, the
containerTop()function was not implemented.Signed-off-by: Dan Ardelean dardelean@cloudbasesolutions.com