-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testutil: Add HyperVSupported check #2062
Conversation
Is this still a draft? |
824ee1a
to
eecbfc5
Compare
Sorry for delay @AkihiroSuda, |
335727a
to
0d9c243
Compare
Figured out why this is failing -_-, there's a process isolated test that checks that the output of
|
The sooner this lands, the better for me. Thanks. |
Been trying to find time, do you want to try and find a good testcase for the test(s) described above that check for the "hyperv" string? This should work after that, frankly this should work right now as is if I removed hyperv from my commit message 😭 |
Perhaps we can check this in and I'll make an issue for us to fix the hyperv string check. CI should pass now that I changed hyperv to hyper-v |
Failures in the CI for 22.04 should be irrelevant |
I've made #2126 to track fixing the process isolated test |
Can this be merged? Would help me in #2145. Thanks. |
CI can't be restarted, could you rebase and push again? |
Will probably be a growing amount of hyper-v tests, and they'll all need this preamble to check if virt/nested virt is turned on. Signed-off-by: Danny Canter <danny@dcantah.dev>
@AkihiroSuda Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Will probably be a growing amount of hyper-v tests, and they'll all need this preamble to check if virt/nested virt is turned on.