-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpacked img size #205
unpacked img size #205
Conversation
images.go
Outdated
@@ -94,7 +95,7 @@ func printImages(ctx context.Context, clicontext *cli.Context, imageList []image | |||
} | |||
|
|||
for _, img := range imageList { | |||
size, err := img.Size(ctx, cs, platforms.DefaultStrict()) | |||
size, err := unpackedImageSize(ctx, clicontext, client, img) | |||
if err != nil { | |||
return errors.Wrap(err, "failed to compute image size") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be logrus.Warn, not return err
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Multiple images may face this warning depending on snapshotter, so a warning should be printed only once)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AkihiroSuda changes applied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but needs squashing
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
fixing #50
Considering that the image unpacked size is the image ChainID snapshot size
Signed-off-by: fahed dorgaa fahed.dorgaa@gmail.com