unpacked img size #205
Merged
unpacked img size #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
May 12, 2021
images.go
Outdated
| @@ -94,7 +95,7 @@ func printImages(ctx context.Context, clicontext *cli.Context, imageList []image | |||
| } | |||
|
|
|||
| for _, img := range imageList { | |||
| size, err := img.Size(ctx, cs, platforms.DefaultStrict()) | |||
| size, err := unpackedImageSize(ctx, clicontext, client, img) | |||
| if err != nil { | |||
| return errors.Wrap(err, "failed to compute image size") | |||
There was a problem hiding this comment.
This should be logrus.Warn, not return err
There was a problem hiding this comment.
(Multiple images may face this warning depending on snapshotter, so a warning should be printed only once)
There was a problem hiding this comment.
@AkihiroSuda changes applied
AkihiroSuda
requested changes
May 13, 2021
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
AkihiroSuda
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #50
Considering that the image unpacked size is the image ChainID snapshot size
Signed-off-by: fahed dorgaa fahed.dorgaa@gmail.com