Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: allow custom handlers for processing push/pull status updates #2342

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor: allow custom handlers for processing push/pull status updates #2342

wants to merge 6 commits into from

Commits on Jul 19, 2023

  1. refactor: allow custom handlers for processing push/pull status updates 

    Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
    @mharwani
    mharwani committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    0ec652e View commit details
    Browse the repository at this point in the history

  2. redirect image pull progress to stderr instead of stdout 

    Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
    @mharwani
    mharwani committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    2db8ffc View commit details
    Browse the repository at this point in the history

  3. refactor EnsureImage in pkg/cmd/pull.go to keep the original arguments 

    Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
    @mharwani
    mharwani committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    ae192be View commit details
    Browse the repository at this point in the history

  4. fix a minor issue and a typo 

    Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
    @mharwani
    mharwani committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    a0caa42 View commit details
    Browse the repository at this point in the history

  5. redirect pull status output to stderr in container create 

    Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
    @mharwani
    mharwani committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    2e36861 View commit details
    Browse the repository at this point in the history

  6. remove stdout from pull/push options in favor of progress handler 

    Signed-off-by: Mrudul Harwani <mharwani@amazon.com>
    @mharwani
    mharwani committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    747fe3d View commit details
    Browse the repository at this point in the history