-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance image history #3020
Enhance image history #3020
Conversation
41985f3
to
e4a16a5
Compare
Hey folks @yankay @AkihiroSuda
Pending CI happiness, let me know what you think and if you want some of that stuff modified. |
Ok, windows is going to give me grief again. How do you folks test locally on windows? Update: I do not understand how to pull a linux image on windows - for now, I have disabled the test on Windows then. |
064eec6
to
4b963c9
Compare
2f8fedc
to
1d68df8
Compare
@AkihiroSuda @yankay though all your comments have been addressed, this is currently blocked, as I can weaken the test for now (eg: not checking Thoughts? |
1d68df8
to
fa7b285
Compare
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
fa7b285
to
099ef7b
Compare
@AkihiroSuda @yankay I disabled the test on select platforms and CI is green. Thanks a lot for your help! |
Thanks @apostasie /lgtm |
Wondering if "/lgtm" with the slash does act as intended. Thanks a ton @yankay ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This fixes some of the issues described in #3019.
Specifically:
This PR stops using
containerd/pkg/progress
and instead goes directly todocker/go-units
for better control.Formatting was done in the image walker, and has been moved down to the printing part instead for better separation of concerns.
What is NOT fixed from #3019: