Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nerdctl run --labels #40

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Add support for nerdctl run --labels #40

merged 1 commit into from
Dec 13, 2020

Conversation

soharaki
Copy link

Signed-off-by: Sho Haraki endurance.test.20380119@gmail.com
/cc @AkihiroSuda

Signed-off-by: Sho Haraki <endurance.test.20380119@gmail.com>
@soharaki
Copy link
Author

$ cat labels 
user=123461
role=cache

$ sudo nerdctl run -l foo=bar -l fuga=piyo --label-file=labels nginx
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
...

$ sudo ctr c info 23938b33c7f53da7d7fc68e02b18107f58870e77e8907d6c0cc1cee4baf31670  | grep Labels -A 5
    "Labels": {
        "foo": "bar",
        "fuga": "piyo",
        "role": "cache",
        "user": "123461"
    },

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit fd8df2e into containerd:master Dec 13, 2020
AkihiroSuda added a commit that referenced this pull request Dec 14, 2020
d898ff0 (#40) broken `--restart=always`
because it accidentally cleared the internal labels.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants