Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-arch support for a nydus-snapshotter image #583

Closed
BbolroC opened this issue Mar 18, 2024 · 2 comments · Fixed by #584 or #585
Closed

Multi-arch support for a nydus-snapshotter image #583

BbolroC opened this issue Mar 18, 2024 · 2 comments · Fixed by #584 or #585

Comments

@BbolroC
Copy link
Contributor

BbolroC commented Mar 18, 2024

The project is currently utilized by confidential-containers. Presently, the CI system is set up exclusively for x86_64 architecture. As the project progresses, there's a need to expand the CI to include support for other platforms. However, the deployment relies on an image, ghcr.io/containerd/nydus-snapshotter, which is only compatible with x86_64 architecture. It would be advantageous to transform this into a multi-arch image using a GitHub Actions workflow.
BbolroC added a commit to BbolroC/nydus-snapshotter that referenced this issue Mar 18, 2024
@BbolroC
action: enable nydus-snapshotter image to support multi-arch
bbb49e9 
This commit is to build and release `ghcr.io/containerd/nydus-snapshotter`
for multiple platforms (below) by leveraging GHA's QEMU/buildx funtionalities.

- amd64
- arm64
- s390x
- ppc64le

Fixes: containerd#583

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC BbolroC mentioned this issue Mar 18, 2024
Merged
BbolroC added a commit to BbolroC/nydus-snapshotter that referenced this issue Mar 18, 2024
@BbolroC
action: enable nydus-snapshotter image to support multi-arch
803684d 
This commit is to build and release `ghcr.io/containerd/nydus-snapshotter`
for multiple platforms (below) by leveraging GHA's QEMU/buildx funtionalities.

- amd64
- arm64
- s390x
- ppc64le

Fixes: containerd#583

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC added a commit to BbolroC/nydus-snapshotter that referenced this issue Mar 18, 2024
@BbolroC
action: enable nydus-snapshotter image to support multi-arch
108e5fe 
This commit is to build and release `ghcr.io/containerd/nydus-snapshotter`
for multiple platforms (below) by leveraging GHA's QEMU/buildx funtionalities.

- amd64
- arm64
- s390x
- ppc64le

Fixes: containerd#583

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@imeoer
Copy link
Collaborator

imeoer commented Mar 18, 2024

@BbolroC :( It seems have a wrap line problem when handle latest and tag:

https://github.com/containerd/nydus-snapshotter/actions/runs/8325473739/job/22779362791

image

@imeoer imeoer reopened this Mar 18, 2024
@BbolroC
Copy link
Contributor Author

BbolroC commented Mar 18, 2024

@imeoer Thanks for sharing the log. I missed a tagging part. I will update the PR. 😉

BbolroC added a commit to BbolroC/nydus-snapshotter that referenced this issue Mar 18, 2024
@BbolroC
action: enable nydus-snapshotter image to support multi-arch
c5ed38f 
This commit is to build and release `ghcr.io/containerd/nydus-snapshotter`
for multiple platforms (below) by leveraging GHA's QEMU/buildx funtionalities.

- amd64
- arm64
- s390x
- ppc64le

Fixes: containerd#583

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC added a commit to BbolroC/nydus-snapshotter that referenced this issue Mar 18, 2024
@BbolroC
action: publish docker manifest only for latest
2ae8bf0 
The PR containerd#584 overlooked a scenario involving more than two elements
in `steps.meta.outputs.tags`. This commit addresses that by iterating
over the tags and creating/pushing a manifest only for tags ending
with `latest`.

Fixes: containerd#583

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC BbolroC mentioned this issue Mar 18, 2024
Merged
BbolroC added a commit to BbolroC/nydus-snapshotter that referenced this issue Mar 18, 2024
@BbolroC
action: publish manifest more than two tags
cc1e89b 
The PR containerd#584 overlooked a scenario involving more than two elements
in `steps.meta.outputs.tags`. This commit addresses that by iterating
over the tags and creating/pushing a manifest for them, respectively.

Fixes: containerd#583

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC added a commit to BbolroC/nydus-snapshotter that referenced this issue Mar 18, 2024
@BbolroC
action: publish manifest for multiple tags
cdee8e6 
The PR containerd#584 overlooked a scenario involving more than two elements
in `steps.meta.outputs.tags`. This commit addresses that by iterating
over the tags and creating/pushing a manifest for them, respectively.

Fixes: containerd#583

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC added a commit to BbolroC/nydus-snapshotter that referenced this issue Mar 18, 2024
@BbolroC
action: publish manifest for multiple tags
4047383 
The PR containerd#584 overlooked a scenario involving more than two elements
in `steps.meta.outputs.tags`. This commit addresses that by iterating
over the tags and creating/pushing a manifest for them, respectively.

Fixes: containerd#583

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC added a commit to BbolroC/nydus-snapshotter that referenced this issue Mar 18, 2024
@BbolroC
action: publish manifest for multiple tags
e707fd1 
The PR containerd#584 overlooked a scenario involving more than two elements
in `steps.meta.outputs.tags`. This commit addresses that by iterating
over the tags and creating/pushing a manifest for them, respectively.

Fixes: containerd#583

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@imeoer @BbolroC