action: enable nydus-snapshotter image to support multi-arch #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BbolroC
force-pushed
the
enable-multi-arch-image
branch
from
bbb49e9
to
803684d
Compare
This commit is to build and release `ghcr.io/containerd/nydus-snapshotter` for multiple platforms (below) by leveraging GHA's QEMU/buildx funtionalities. - amd64 - arm64 - s390x - ppc64le Fixes: containerd#583 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
force-pushed
the
enable-multi-arch-image
branch
from
803684d
to
108e5fe
Compare
|
@BbolroC Thanks for the PR! |
imeoer
approved these changes
Mar 18, 2024
|
@BbolroC Let's release |
BbolroC
added a commit
to BbolroC/nydus-snapshotter
that referenced
this pull request
Mar 18, 2024
The PR containerd#584 overlooked a scenario involving more than two elements in `steps.meta.outputs.tags`. This commit addresses that by iterating over the tags and creating/pushing a manifest only for tags ending with `latest`. Fixes: containerd#583 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
added a commit
to BbolroC/nydus-snapshotter
that referenced
this pull request
Mar 18, 2024
The PR containerd#584 overlooked a scenario involving more than two elements in `steps.meta.outputs.tags`. This commit addresses that by iterating over the tags and creating/pushing a manifest for them, respectively. Fixes: containerd#583 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
added a commit
to BbolroC/nydus-snapshotter
that referenced
this pull request
Mar 18, 2024
The PR containerd#584 overlooked a scenario involving more than two elements in `steps.meta.outputs.tags`. This commit addresses that by iterating over the tags and creating/pushing a manifest for them, respectively. Fixes: containerd#583 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
added a commit
to BbolroC/nydus-snapshotter
that referenced
this pull request
Mar 18, 2024
The PR containerd#584 overlooked a scenario involving more than two elements in `steps.meta.outputs.tags`. This commit addresses that by iterating over the tags and creating/pushing a manifest for them, respectively. Fixes: containerd#583 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
added a commit
to BbolroC/nydus-snapshotter
that referenced
this pull request
Mar 18, 2024
The PR containerd#584 overlooked a scenario involving more than two elements in `steps.meta.outputs.tags`. This commit addresses that by iterating over the tags and creating/pushing a manifest for them, respectively. Fixes: containerd#583 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to build and release
ghcr.io/containerd/nydus-snapshotterfor multiple platforms (below) by leveraging GHA's QEMU/buildx funtionalities.The workflow was verified and the image is available at https://github.com/BbolroC/nydus-snapshotter/pkgs/container/nydus-snapshotter/179477460?tag=enable-multi-arch-image.
Fixes: #583
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com