Collect nydusd startup cpu utilization and report its mem usage #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 33.30% // Head: 33.06% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 33.30% 33.06% -0.24%
==========================================
Files 29 29
Lines 3129 3151 +22
==========================================
Hits 1042 1042
- Misses 1979 2001 +22
Partials 108 108
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
changweige
force-pushed
the
nydusd-cpu-resouces
branch
5 times, most recently
from
916878e
to
0662489
Compare
|
Moreover, LGTM. |
sctb512
reviewed
Dec 13, 2022
| @@ -32,27 +33,48 @@ var ( | |||
| PageSize = GetPageSize() | |||
| ) | |||
|
|
|||
| func GetCurrentStat(pid int) (*Stat, error) { | |||
| func CalculateCPUUtilization(begin *Stat, now *Stat) float64 { | |||
| cpuSys := (now.Stime - begin.Stime) / ClkTck | |||
There was a problem hiding this comment.
Maybe we should check whether the begin and now are not nil before using them.
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
changweige
force-pushed
the
nydusd-cpu-resouces
branch
from
0662489
to
a02f614
Compare
|
@sctb512 Mind take another look? |
sctb512
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect some metrics about nydusd system resource consumption during its startup procedure.
It will be helpful when analyze application startup latency