fix k8s e2e test docker file #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 30.50% // Head: 30.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 30.50% 30.57% +0.07%
==========================================
Files 37 37
Lines 3800 3800
==========================================
+ Hits 1159 1162 +3
+ Misses 2520 2517 -3
Partials 121 121
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sctb512
reviewed
Jan 16, 2023
| @@ -17,10 +17,7 @@ if [ "$#" -eq 0 ]; then | |||
| --root ${NYDUS_LIB} \ | |||
| --address ${NYDUS_RUN}/containerd-nydus-grpc.sock \ | |||
| --log-level ${LEVEL} \ | |||
| --enable-metrics=${ENABLE_METRICS} \ | |||
There was a problem hiding this comment.
Shall we remove the related variables as well?
ENABLE_NYDUS_OVERLAY="${ENABLE_NYDUS_OVERLAY:-true}"
ENABLE_METRICS="${ENABLE_METRICS:-false}"There was a problem hiding this comment.
Good point, already removed
changweige
force-pushed
the
fix-docker-file
branch
from
103e59e
to
101aea7
Compare
Parpare for making full use of toml based config file. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
changweige
force-pushed
the
fix-docker-file
branch
from
101aea7
to
9359154
Compare
changweige
changed the title
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
changweige
force-pushed
the
fix-docker-file
branch
from
9359154
to
f9fe9d4
Compare
imeoer
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the nydus-snapshotter CLI parameters in k8s e2e test docker file where several CLI parameters are removed