Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add document about hot update mirror configurations #347

Merged

Conversation

sctb512
Copy link
Member

@sctb512 sctb512 commented Feb 6, 2023

Signed-off-by: Bin Tang tangbin.bin@bytedance.com

@sctb512 sctb512 force-pushed the add-doc-for-hot-update-mirror-conf branch 3 times, most recently from 9072311 to 72fc9aa Compare February 6, 2023 07:37
README.md Outdated
@@ -170,6 +170,25 @@ Dragonfly supports both **mirror** mode and HTTP **proxy** mode to boost the con

`auth_through=false` means nydusd's authentication request will directly go to original registry rather than relayed by Dragonfly.

### Hot update mirror configurations
In addition to setting the registry mirror in nydusd's json configuration file, `nydus-snapshotter` also supports hot update mirror configurations. You can set the configuration directory in nudus-snapshotter's toml configuration file with `remote.mirrors_config`. The null string for `remote.mirrors_config` means disable it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean remote.mirrors_config.dir ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about " empty remote.mirrors_config.dir means disabling it`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

README.md Outdated
server = "https://p2p-nydus.com"
[host]
[host."http://127.0.0.1:65001"]
auth_through = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested value of auth_through should be false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@sctb512 sctb512 force-pushed the add-doc-for-hot-update-mirror-conf branch from 72fc9aa to fd92f1f Compare February 6, 2023 09:11
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
@sctb512 sctb512 force-pushed the add-doc-for-hot-update-mirror-conf branch from fd92f1f to 1e9b674 Compare February 6, 2023 09:40
@changweige changweige merged commit fcca6f9 into containerd:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants