Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow nydusd and nydus-image absence in PATH #399

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

changweige
Copy link
Member

Nydusd and nydus-image's path be customized.
It should throw error if they can't be found.

Nydusd and nydus-image's path be customized.
It should throw error if they can't be found.

Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (b0c8c5d) 29.37% compared to head (c6dd694) 29.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   29.37%   29.42%   +0.05%     
==========================================
  Files          40       40              
  Lines        4096     4089       -7     
==========================================
  Hits         1203     1203              
+ Misses       2744     2735       -9     
- Partials      149      151       +2     
Impacted Files Coverage Δ
config/default.go 80.00% <0.00%> (+5.00%) ⬆️
pkg/blob/blob_manager.go 32.65% <0.00%> (+3.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sctb512 sctb512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changweige changweige merged commit a789781 into containerd:main Mar 6, 2023
@changweige changweige deleted the nydus-bin-can-not-exist branch March 7, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants