-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
referrer: fix panic on enable_referrer_detect enabled #459
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
=======================================
Coverage 37.31% 37.31%
=======================================
Files 59 59
Lines 6960 6960
=======================================
Hits 2597 2597
Misses 4052 4052
Partials 311 311
|
Can we have an E2E test of the OCI referrer feature too? |
Say an error likes the issue #458 tells it's fragile |
@imeoer Is it possible to add a test alongside this PR? If you don't have bandwidth right now, it's fine for me to merge this fix only now |
The panic occurs when `enable_referrer_detect = true` is enabled in config.toml: ``` panic: interface conversion: docker.dockerFetcher is not remotes.ReferrersFetcher: missing method FetchReferrers runtime/debug.Stack() ``` Fixed it by replacing all `github.com/containerd/containerd/remotes` package to `github.com/containerd/nydus-snapshotter/pkg/remote/remotes` in `remote` package. Fix containerd#458 Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
5db686d
to
b72251b
Compare
Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
Added, PTAL. |
KEY="${1}" | ||
VALUE="${2}" | ||
|
||
sed -i "s/\($KEY *= *\).*/\1$VALUE/" "${SNAPSHOTTER_CONFIG}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works but not generic since it ignores the toml hierarchy. It's fine for now
The panic occurs when
enable_referrer_detect = true
is enabled in config.toml:Fixed it by replacing all
github.com/containerd/containerd/remotes
package togithub.com/containerd/nydus-snapshotter/pkg/remote/remotes
inremote
package.Fix #458