referrer: fix panic on enable_referrer_detect enabled #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
=======================================
Coverage 37.31% 37.31%
=======================================
Files 59 59
Lines 6960 6960
=======================================
Hits 2597 2597
Misses 4052 4052
Partials 311 311
|
|
Can we have an E2E test of the OCI referrer feature too? |
|
Say an error likes the issue #458 tells it's fragile |
jiangliu
approved these changes
May 2, 2023
|
@imeoer Is it possible to add a test alongside this PR? If you don't have bandwidth right now, it's fine for me to merge this fix only now |
The panic occurs when `enable_referrer_detect = true` is enabled in config.toml: ``` panic: interface conversion: docker.dockerFetcher is not remotes.ReferrersFetcher: missing method FetchReferrers runtime/debug.Stack() ``` Fixed it by replacing all `github.com/containerd/containerd/remotes` package to `github.com/containerd/nydus-snapshotter/pkg/remote/remotes` in `remote` package. Fix containerd#458 Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
force-pushed
the
fix_referrer
branch
3 times, most recently
from
5db686d
to
b72251b
Compare
Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
Added, PTAL. |
changweige
reviewed
May 16, 2023
| KEY="${1}" | ||
| VALUE="${2}" | ||
|
|
||
| sed -i "s/\($KEY *= *\).*/\1$VALUE/" "${SNAPSHOTTER_CONFIG}" |
There was a problem hiding this comment.
This works but not generic since it ignores the toml hierarchy. It's fine for now
changweige
approved these changes
May 16, 2023
changweige
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The panic occurs when
enable_referrer_detect = trueis enabled in config.toml:Fixed it by replacing all
github.com/containerd/containerd/remotespackage togithub.com/containerd/nydus-snapshotter/pkg/remote/remotesinremotepackage.Fix #458