Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Supplementary for containerd configuration required by snapshotter #573

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

ChengyuZhu6
Copy link
Contributor

Supplementary for containerd configuration required by nydus snapshotter: disable_snapshot_annotations and
discard_unpacked_layers.

…apshotter

Supplementary for containerd configuration required by nydus
snapshotter: `disable_snapshot_annotations` and
`discard_unpacked_layers`.

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0397a1f) 33.63% compared to head (0041455) 33.52%.
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   33.63%   33.52%   -0.12%     
==========================================
  Files          65       65              
  Lines        8259     8287      +28     
==========================================
  Hits         2778     2778              
- Misses       5166     5194      +28     
  Partials      315      315              

see 1 file with indirect coverage changes

Copy link
Contributor

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ChengyuZhu6!

@sctb512
Copy link
Member

sctb512 commented Jan 12, 2024

LGTM

@imeoer imeoer merged commit cc66508 into containerd:main Jan 15, 2024
16 checks passed
@ChengyuZhu6 ChengyuZhu6 deleted the config branch January 30, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants