Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error in Kubelet when using default root directory #603

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

fappy1234567
Copy link

Relevant Issue

Fixes #288

Details

Setting the snapshotter's default root path to /var/lib/containerd/io.containerd.snapshotter.v1.nydus can resolve the issue.

@imeoer
Copy link
Collaborator

imeoer commented Jul 11, 2024

Thanks for the PR! but it seems the string /var/lib/containerd-nydus is across multiple files, can we correct them all?

@fappy1234567
Copy link
Author

@imeoer Thank you for your feedback and review! I have checked and updated the string /var/lib/containerd-nydus across all relevant files, except for two yaml files in the \tests\e2e\k8s directory. Please review the changes and let me know if there's anything else that needs to be adjusted.

@imeoer
Copy link
Collaborator

imeoer commented Jul 15, 2024

@fappy1234567 Thanks, I think there's no reason to keep tests/e2e/k8s, and the README.md needs also to be updated. :)

@fappy1234567
Copy link
Author

@imeoer I've already updated the README.md. Let me know if there's anything else that needs attention.

@imeoer
Copy link
Collaborator

imeoer commented Jul 15, 2024

@fappy1234567 Thanks, the tests/e2e/k8s also need to be updated.

@fappy1234567
Copy link
Author

@imeoer Thank you for your guidance. I have also updated the tests/e2e/k8s section, but there are some checks that are not passing. When you have a moment, could you please take a look and see if there is anything that needs to be adjusted? Thank you very much!

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit 239009a into containerd:main Jul 17, 2024
15 of 16 checks passed
This was referenced Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubelet log has error when use default root dir
3 participants