untar: support pax xattr header #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liulanzheng
reviewed
Dec 15, 2023
src/overlaybd/tar/header.cpp
Outdated
| @@ -83,6 +83,14 @@ std::string remove_last_slash(const std::string_view &path) { | |||
| return std::string(path); | |||
| } | |||
|
|
|||
| bool has_prefix(const std::string_view &str, const std::string_view &prefix) { | |||
There was a problem hiding this comment.
it's better to use estring_view.starts_with
src/overlaybd/tar/header.cpp
Outdated
| @@ -83,6 +83,14 @@ std::string remove_last_slash(const std::string_view &path) { | |||
| return std::string(path); | |||
| } | |||
|
|
|||
| bool has_prefix(const std::string_view &str, const std::string_view &prefix) { | |||
There was a problem hiding this comment.
it's better to use estring_view.starts_with
remove overlaybd/extfs and use photon/extfs instead. Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove overlaybd/extfs and use photon/extfs instead.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes containerd/accelerated-container-image#251
Please check the following list: