-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
untar: support pax xattr header #302
Conversation
src/overlaybd/tar/header.cpp
Outdated
@@ -83,6 +83,14 @@ std::string remove_last_slash(const std::string_view &path) { | |||
return std::string(path); | |||
} | |||
|
|||
bool has_prefix(const std::string_view &str, const std::string_view &prefix) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to use estring_view.starts_with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
src/overlaybd/tar/header.cpp
Outdated
@@ -83,6 +83,14 @@ std::string remove_last_slash(const std::string_view &path) { | |||
return std::string(path); | |||
} | |||
|
|||
bool has_prefix(const std::string_view &str, const std::string_view &prefix) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to use estring_view.starts_with
remove overlaybd/extfs and use photon/extfs instead. Signed-off-by: yuchen.cc <yuchen.cc@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
remove overlaybd/extfs and use photon/extfs instead.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes containerd/accelerated-container-image#251
Please check the following list: