refactor(*): add source.as_bytes() #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
requested changes
Jan 18, 2024
Mossaka
changed the title
jprendes
reviewed
Jan 18, 2024
Mossaka
changed the title
jsturtevant
reviewed
Jan 18, 2024
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
jprendes
reviewed
Jan 22, 2024
| .resolve_in_path_or_cwd() | ||
| .next() | ||
| .context("module not found")?; | ||
| Ok(Cow::Owned(std::fs::read(path)?)) |
There was a problem hiding this comment.
thought: We optimize for no copy in the Oci case by using Cow, but we read the file every time in the File case. Might be premature optimiation, but the file content could be cached in memory here to avoid multiple reads.
I'm fine with leaving it as it is because the unoptimized File case would be the legacy workflow. Also we could revisit if we ever observe any perforance bottleneck here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preferred way to refactor the usage of
Sourceinto aas_bytes()function in Context. It does not change the APIs of the Engine trait. Closes #448