feat: add cgroup v2 support for metrics #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds cgroup v2 support for collecting metrics in the shim. Additionally, it uses CPU controller instead of the CPUAcct controller for reporting CPU metrics back to containerd. Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
|
This PR includes changes from #161 |
Absolutely. Done :) |
|
LGTM Would it be worth adding rust-extensions/.github/workflows/ci.yml Line 96 in 27a503a |
mxpv
approved these changes
Aug 3, 2023
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
|
Could we merge this? @mxpv |
|
Done! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds cgroup v2 support for collecting metrics in the shim.
Additionally, it uses CPU controller instead of the CPUAcct controller
for reporting CPU metrics back to
containerd.Closes #162