feat: add stats function to task #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
rumpl
reviewed
Aug 1, 2023
| let mut metrics = Metrics::new(); | ||
| let hier = hierarchies::auto(); | ||
| let cgroup: Cgroup; | ||
| if hier.v2() { |
There was a problem hiding this comment.
Fun fact, hier means "yesterday" in french :)
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
This commits adds CPUAcct and Pid metircs to report to containerd Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
This commit uses the cpu controller to collect stats from the CPU instead of the cpuacct controller. Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
|
I am now able to get more metrics, including CPU and PIDs!! ➜ runwasi git:(stats) ✗ sudo ctr task metric testwasm
ID TIMESTAMP
testwasm seconds:1690930464 nanos:407172844
METRIC VALUE
memory.usage_in_bytes 18649088
memory.limit_in_bytes 0
memory.stat.cache 0
cpuacct.usage 3545445
cpuacct.usage_percpu []
pids.current 9
pids.limit 0 |
|
Just ran the |
|
can we re-use the work you did in containerd/rust-extensions#163? |
sure that's my intention |
devigned
approved these changes
Aug 4, 2023
|
Will merge this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
statsfunction to the implementation of a Task. It usescgroups_rscrate to get the memory stats from cgroup subsystems, which is largely inspired by how containerd runc shim is implemented in rust-extensions repo.This is currently work-in-process but I want to get it out there so to collect some early feedback.
If you want to test it, you can use
ctr task metric <task-name>to print out the memory usage of the taskTODO:
Closes #208