Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate vendoring proto files from containerd #244

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Conversation

mxpv
Copy link
Member

@mxpv mxpv commented Feb 16, 2024

This PR adds update-vendor.sh script to scripts/ directory to automate updating vendoring changes. For now the script must be ran manually.

# A simple bash script to synchronize proto files from containerd to vendor/ directories of
# each crate.
#
# VERSION specified containerd release that script will download to extract protobuf files.
#
# For each crate, the script expects a text file named `rsync.txt` in the crate's directory.
# The file should contain a list of proto files that should be synchronized from containerd.

ref: #202

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@github-actions github-actions bot added C-shim-protos Shim protos C-client Containerd client C-snapshots Remote snapshotter labels Feb 16, 2024
@mxpv mxpv changed the title Add a simple script to update vendor Automate vendoring proto files from containerd Feb 16, 2024
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@mxpv mxpv marked this pull request as ready for review February 16, 2024 18:46
@mxpv mxpv requested a review from a team February 16, 2024 18:48
set -x

# Download containerd source code.
gh release download $VERSION \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh is not a frequently used command, what about wget or curl?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0dc97ad

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49a4a83) 37.90% compared to head (0dc97ad) 38.08%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   37.90%   38.08%   +0.18%     
==========================================
  Files          55       55              
  Lines        5060     5099      +39     
==========================================
+ Hits         1918     1942      +24     
- Misses       3142     3157      +15     
Flag Coverage Δ
unittests 38.08% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv added this pull request to the merge queue Feb 22, 2024
Merged via the queue into containerd:main with commit cc445f5 Feb 22, 2024
18 checks passed
@mxpv mxpv deleted the vendor branch February 22, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-client Containerd client C-shim-protos Shim protos C-snapshots Remote snapshotter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants