Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI project checks to use containerd project action #101

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

dmcgowan
Copy link
Member

Cleans up CI some and uses a similar approach to other repos

Signed-off-by: Derek McGowan <derek@mcg.dev>
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #101 (e066ce6) into main (0247db1) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   72.52%   72.55%   +0.02%     
==========================================
  Files          11       11              
  Lines         728      725       -3     
==========================================
- Hits          528      526       -2     
+ Misses        158      157       -1     
  Partials       42       42              
Impacted Files Coverage Δ
types.go 16.66% <ø> (+1.28%) ⬆️
unixcreds_linux.go 56.75% <ø> (+2.91%) ⬆️
client.go 77.61% <0.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0247db1...e066ce6. Read the comment docs.

@dmcgowan dmcgowan force-pushed the update-ci branch 11 times, most recently from 4379996 to 3351170 Compare January 21, 2022 05:06
Copy link

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan force-pushed the update-ci branch 6 times, most recently from 805e205 to d18d5a8 Compare January 21, 2022 19:55
Cleanup server test

Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit a362a13 into containerd:main Jan 21, 2022
kzys added a commit to kzys/ttrpc that referenced this pull request Feb 22, 2022
We have lost Codecov since containerd#101. While the main containerd repository
doesn't have that, ttrpc could have Codecov without much complications.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@kzys kzys mentioned this pull request Feb 22, 2022
kzys added a commit to kzys/ttrpc that referenced this pull request Feb 22, 2022
We have lost Codecov since containerd#101. While the main containerd repository
doesn't have that, ttrpc could have Codecov without much complications.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants