Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Codecov again #105

Merged
merged 1 commit into from Feb 22, 2022
Merged

Enable Codecov again #105

merged 1 commit into from Feb 22, 2022

Conversation

kzys
Copy link
Member

@kzys kzys commented Feb 22, 2022

We have lost Codecov since #101. While the main containerd repository
doesn't have that, ttrpc could have Codecov without much complications.

Signed-off-by: Kazuyoshi Kato katokazu@amazon.com

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #105 (79bcb78) into main (d2d6bb6) will decrease coverage by 9.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   72.80%   63.67%   -9.13%     
==========================================
  Files          11       11              
  Lines         728     1049     +321     
==========================================
+ Hits          530      668     +138     
- Misses        156      336     +180     
- Partials       42       45       +3     
Impacted Files Coverage Δ
client.go
codec.go
handshake.go
interceptor.go
services.go
unixcreds_linux.go
server.go
metadata.go
channel.go
config.go
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35aa96...79bcb78. Read the comment docs.

We have lost Codecov since containerd#101. While the main containerd repository
doesn't have that, ttrpc could have Codecov without much complications.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@dmcgowan
Copy link
Member

The inaccurate comment kind of highlights why we got rid of it in the first place. Are we using it wrong? If it just consistently adds meaningless comments with numbers that don't indicate anything, we shouldn't reenable. If we just need to fix some configuration and it will actually work, then sure.

@kzys
Copy link
Member Author

kzys commented Feb 22, 2022

We haven't sent information to Codecov for roughly a month. Having outdated information on their end (hence reporting the drop) makes some sense.

I'd like to give it a try. If it still fluctuates for a few months, we can remove the action.

Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll see 😉

@dmcgowan dmcgowan merged commit aa5c947 into containerd:main Feb 22, 2022
@kzys kzys mentioned this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants