Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace juju/errors because of CNCF license scan #458

Merged
merged 2 commits into from
Apr 1, 2020
Merged

replace juju/errors because of CNCF license scan #458

merged 2 commits into from
Apr 1, 2020

Conversation

mars1024
Copy link
Member

ref to #457

@bboreham
Copy link
Contributor

The basic idea is OK, but now Go stdlib has %w I think we should use that.
Since we don't want to force everyone to upgrade to Go 1.13, this could be a wrapper function inside a utility package here. It could even be named errors.Annotate to reduce diffs.

@mars1024 mars1024 force-pushed the remove/jujuerrors branch 2 times, most recently from fd91c21 to 9caeba1 Compare March 11, 2020 12:31
@mars1024
build error utility package to replace juju/errors
8a0e3fe 
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
@mars1024
Copy link
Member Author

The basic idea is OK, but now Go stdlib has %w I think we should use that.
Since we don't want to force everyone to upgrade to Go 1.13, this could be a wrapper function inside a utility package here. It could even be named errors.Annotate to reduce diffs.

Thanks, added an error utility package as wrapper to reduce diffs.

@mars1024
[DO NOT REVIEW] vendor upate to remove useless dependencies
486ef96 
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
bboreham
bboreham approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@squeed
Copy link
Member

squeed commented Apr 1, 2020

lgtm!

@squeed squeed merged commit 117e30f into containernetworking:master Apr 1, 2020
@antoninbas antoninbas mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mars1024 @bboreham @squeed