Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Configure Renovate #270

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 9, 2022

Mend Renovate

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.


Detected Package Files

  • Cargo.toml (cargo)
  • .github/workflows/check_cirrus_cron.yml (github-actions)
  • .github/workflows/rerun_cirrus_cron.yml (github-actions)

Configuration

🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.

Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.

What to Expect

With your current configuration, Renovate will create 1 Pull Request:

fix(deps): update rust crate clap to v4
  • Schedule: ["at any time"]
  • Branch name: renovate/clap-4.x
  • Merge into: main
  • Upgrade clap to 4.0.0

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.


This PR has been generated by Mend Renovate. View repository job log here.

@cevich
Copy link
Member

cevich commented Dec 13, 2022

@containers/netavark-maintainers I think this is ready, PTAL and let me know if you think renovate is missing any deps. that should be updated (according to dependabot).

@cevich
Copy link
Member

cevich commented Jan 18, 2023

Having not received any response, I'm going to assume the dependency-updates indicated in the description are accurate.

@cevich cevich marked this pull request as ready for review January 18, 2023 16:34
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot really comment on the config settings but the change itself LGTM, do we need to disable dependabot afterwards?

Also should this really skip CI, last time you did this we got in big trouble?

@cevich
Copy link
Member

cevich commented Jan 25, 2023

do we need to disable dependabot afterwards?

Eventually yes. The two will play nicely together, you'll just end up with duplicate PRs. That's not important though, what's critical is if dependabot opens PRs that renovate does not (within 24hrs). That's something I need to know about.

Also should this really skip CI, last time you did this we got in big trouble?

The cause of that should be fixed now, but it's worthwhile avoiding. I'll see about getting a CI run done on this PR...

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich changed the title Configure Renovate [CI:DOCS] Configure Renovate Jan 30, 2023
@cevich
Copy link
Member

cevich commented Feb 1, 2023

This PR is ready to merge.

@cevich cevich requested review from Luap99 and a team February 13, 2023 14:08
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c93107b into main Feb 13, 2023
@renovate renovate bot deleted the renovate/configure branch February 13, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants