Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

set-eh: added commands to set event handlers in the manifest #81

Merged
merged 1 commit into from
Oct 30, 2015

Conversation

cgonyeo
Copy link
Member

@cgonyeo cgonyeo commented Oct 28, 2015

Fixes #77.

@jonboulle
Copy link
Contributor

Hrm, I wonder if there's something we can do here to future-proof appc/spec#58 / rkt/rkt#1495

@cgonyeo
Copy link
Member Author

cgonyeo commented Oct 29, 2015

I imagine if the spec gets changed that more fields would just be added to the event handler object. The tweak that would happen here to accommodate those could just be requiring more arguments get passed in to the command, so something like:

acbuild set-eh pre-start root:root /root/setup-stuff.sh

Changes like that would be fairly easy with the current implementation. If we want to allow for more complex changes (like changing the uid for an existing event handler) another option would be to add subcommands onto pre-fetch and post-stop, but those changes would require more rewriting of this.

@jonboulle
Copy link
Contributor

OK. I guess let's just roll forward and we can cross that bridge. LGTM.

cgonyeo pushed a commit that referenced this pull request Oct 30, 2015
set-eh: added commands to set event handlers in the manifest
@cgonyeo cgonyeo merged commit ad637de into containers:master Oct 30, 2015
@cgonyeo cgonyeo deleted the set-event-handlers branch October 30, 2015 21:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants