-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would be nice to have a different 'buildah pull' exit code for network failures #1499
Comments
In this particular case, on Fedora 30, the
Logs in full:
|
@ashley-cui Would you look into this? |
@QiWang19 Could you look into this? |
error might be turned by buildah/vendor/github.com/containers/image/docker/docker_client.go. Does buildah return different exit code for different type of errors? I only see exit status 1 |
Currently no, but the request here is that we do, I believe. |
Close containers#1499 Add different exit code for buildah pull network failures. Check net.Error or defined network error. Signed-off-by: Qi Wang <qiwan@redhat.com>
#1504 |
This was a feature request to use a different exit code to #1504 fixes a bug that could be abused to repeatedly trigger a network failure, but doesn't add any new exit codes to represent those situations. |
I filed a similar feature request for |
Description
Every once in a while, I come across people who failed to create a toolbox container because
buildah pull
errored out for some reason. For example:And if you use the
--verbose
flag you get to see the spew frombuildah pull
.More often than not (almost always?) these are passing network errors. I have seen them myself once or twice, and trying it again gets you past the failure. It would be nice if
toolbox
could throw a more indicative error message that makes it clear that it was due to a network failure or such, instead of a generic string that makes people want to file a bug. :)A brief reading of
cmd/buildah/pull.go
andpull.go
makes me think that there's no specific exit code to indicate why thebuildah pull
failed, but I can't be sure because these failures are not deterministic.Output of
rpm -q buildah
orapt list buildah
:Output of
buildah version
:Output of
cat /etc/*release
:Output of
uname -a
:Output of
cat /etc/containers/storage.conf
:The text was updated successfully, but these errors were encountered: