-
Notifications
You must be signed in to change notification settings - Fork 769
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildah run breaks stdin by setting O_NONBLOCK
#3152
Comments
Is this something buildah could easily change back on exit? |
It could just restore the previous descriptor flags, I suppose. |
Interested in opening a PR? |
Interested yes, but I unfortunately don't have the time to get familiar with the code and Go, at least not in the near future... |
We have talked about this, and we are not sure there is an easy way to fix. |
A friendly reminder that this issue had no activity for 30 days. |
A friendly reminder that this issue had no activity for 30 days. |
Fixes: containers#3152 Sometimes after running buildah run in a terminal, commands executed afterwards which try to read from stdin fail with EAGAIN. This is because it sets O_NONBLOCK on the FD: [NO TESTS NEEDED] Since I don't know how to test this. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Fixes: containers#3152 Sometimes after running buildah run in a terminal, commands executed afterwards which try to read from stdin fail with EAGAIN. This is because it sets O_NONBLOCK on the FD: [NO TESTS NEEDED] Since I don't know how to test this. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Fixes: containers#3152 Sometimes after running buildah run in a terminal, commands executed afterwards which try to read from stdin fail with EAGAIN. This is because it sets O_NONBLOCK on the FD: [NO TESTS NEEDED] Since I don't know how to test this. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Fixes: containers#3152 Sometimes after running buildah run in a terminal, commands executed afterwards which try to read from stdin fail with EAGAIN. This is because it sets O_NONBLOCK on the FD: [NO TESTS NEEDED] Since I don't know how to test this. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Fixes: containers#3152 Sometimes after running buildah run in a terminal, commands executed afterwards which try to read from stdin fail with EAGAIN. This is because it sets O_NONBLOCK on the FD: [NO TESTS NEEDED] Since I don't know how to test this. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Fixes: containers#3152 Sometimes after running buildah run in a terminal, commands executed afterwards which try to read from stdin fail with EAGAIN. This is because it sets O_NONBLOCK on the FD: [NO TESTS NEEDED] Since I don't know how to test this. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Fixes: containers#3152 Sometimes after running buildah run in a terminal, commands executed afterwards which try to read from stdin fail with EAGAIN. This is because it sets O_NONBLOCK on the FD: [NO TESTS NEEDED] Since I don't know how to test this. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Sometimes after running
buildah run
in a terminal, commands executed afterwards which try to read fromstdin
fail withEAGAIN
. This is because it setsO_NONBLOCK
on the FD:strace -k
shows that this is caused by therunCopyStdio
function:buildah/run_linux.go
Line 1236 in c891ebe
For some reason this doesn't happen all the time and the
O_NONBLOCK
flag also disappears after some time, even afterbuildah
exited. I suspect that the interactive shell is fixing that up at some point.The text was updated successfully, but these errors were encountered: