Add default transport to push if not provided #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/pushfix
branch
from
74fa055
to
2443a77
Compare
rhatdan
reviewed
Sep 10, 2017
cmd/buildah/push.go
Outdated
| if err != nil { | ||
| return err | ||
| if !strings.Contains(destSpec, "://") { |
There was a problem hiding this comment.
Reverse the error
if err strings.Container(destSpec,"://") {
return err
}
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/pushfix
branch
3 times, most recently
from
d1baa9e
to
7c5cfdb
Compare
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/pushfix
branch
from
7c5cfdb
to
f1b6b46
Compare
|
LGTM |
|
@nalind PTAL |
|
LGTM |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 19, 2017
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Closes: #260 Approved by: rhatdan
|
💥 Test timed out |
|
@rh-atomic-bot retest |
|
@rh-atomic-bot retry |
1 similar comment
|
@rh-atomic-bot retry |
|
@rh-atomic-bot retest |
|
☀️ Test successful - status-redhatci |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com
Currently with 'buildah push' if the transport is not defined, it will fail. This change will retry if a transport was not found by adding "docker://" to the front of the destination image and retrying.
I tweaked a test in the test script to test for this condition and also converted the creation of htpasswd from Docker to Buildah. I tried running the registry with Buildah too, but 'docker login' wasn't happy. More investigation there in a follow up.