Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'kpod push' doesn't use default transport #40

Closed
TomSweeneyRedHat opened this issue Nov 13, 2017 · 3 comments
Closed

'kpod push' doesn't use default transport #40

TomSweeneyRedHat opened this issue Nov 13, 2017 · 3 comments
Assignees
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@TomSweeneyRedHat
Copy link
Member

If you don't specify a transport, kpod push doesn't default to a transport. It probably should default to "docker://" if a transport is not provided. A similar fix was made to Buildah at: containers/buildah#260

In the examples below, "docker://" is not specified as the transport in the first call and kpod push fails. It then completes when specified.

# kpod push --cert-dir /root/auth docker.io/library/alpine:latest dockreg.redhat.com:5000/my-alpine2
error getting destination imageReference for "dockreg.redhat.com:5000/my-alpine2": Invalid image name "dockreg.redhat.com:5000/my-alpine2", unknown transport "dockreg.redhat.com"
[root@localhost tmp]# kpod push --cert-dir /root/auth docker.io/library/alpine:latest docker://dockreg.redhat.com:5000/my-alpine2
Getting image source signatures

@TomSweeneyRedHat
Copy link
Member Author

I can't assign this to myself? Regardless, I'm going to grab it.

@rhatdan
Copy link
Member

rhatdan commented Nov 14, 2017

Assigned.

@TomSweeneyRedHat
Copy link
Member Author

Fixed by #42

baude pushed a commit to baude/podman that referenced this issue Aug 31, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

2 participants