-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add support for buildkit like --mount=type=bind
#3548
build: Add support for buildkit like --mount=type=bind
#3548
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2029320
to
659d6c3
Compare
@containers/buildah-maintainers @giuseppe @rhatdan @nalind @vrothberg PTAL |
8c78cd0
to
aedfcb8
Compare
aedfcb8
to
7943032
Compare
All kinds of test unhappiness @flouthoc |
@TomSweeneyRedHat I think its quay flakes Edit: Some passed, some still flaky |
084a36c
to
dbe2b46
Compare
resolved conflicts after recent commits in main |
dbe2b46
to
5ad284f
Compare
5ad284f
to
62c1da3
Compare
@cevich @containers/buildah-maintainers I am not sure but looks like something is up with CI for Conformance test its failing for all the PR's with error |
Opened #3560 to fix CI |
1343155
to
0d686e8
Compare
@nalind Added requested tests, I still need to implement |
0d686e8
to
ba9e00c
Compare
@nalind I think |
ba9e00c
to
178f86b
Compare
f27ab79
to
11f7f93
Compare
Rebasing after #3562 |
LGTM |
6f01322
to
63a27a3
Compare
Following commit adds support for using buildkit like `--mount=type=bind` with `RUN` statements. Mounts created by `--mount` are transient in nature and only scoped to current RUN statements. Signed-off-by: Aditya Rajan <arajan@redhat.com>
63a27a3
to
f0d3140
Compare
case "readonly": | ||
// Alias for "ro" | ||
newMount.Options = append(newMount.Options, "ro") | ||
case "shared", "rshared", "private", "rprivate", "slave", "rslave", "Z", "z": | ||
case "shared", "rshared", "private", "rprivate", "slave", "rslave", "Z", "z", "U": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have test coverage for the "U" flag when used here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nalind Mount code is being reused from volumes and tests for U
is already added here https://github.com/containers/buildah/blob/main/tests/run.bats#L304 therefore I refrained from adding ownership
test to prevent redundancy
Question about test coverage of the "U" flag, otherwise LGTM. |
/lgtm |
Following commit adds support for using buildkit like
--mount=type=bind
withRUN
statements.Mounts created by
--mount
are transient in nature and only scoped to current RUN statements just likebuildkit
.Example
PS: docs already have entry for this but it was never implemented.
Closes: #3217