-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cirrus: remove static_build
#3680
cirrus: remove static_build
#3680
Conversation
30f7a6a
to
57ee2fe
Compare
@edsantiago @cevich Just checking if static build works with last stable version just like |
IMHO, this will likely be a temporary fix at best. While it's slowed down recently, eventually crun will be updated and we'll be back in the same boat.
I'm okay with removing it now if that's easier & others agree. AFAIK the nix stuff isn't backed by anyone anymore, and so that begs the question if anybody actually cares about the CI result. If we simply need a static binary artifact/test, it should be possible to do that using automation we're willing to own/maintain. |
@hswong3i PTAL |
@saschagrunert PTAL |
Remove `static_build` from ci as it is becoming hard to keep up with `nix` hiccups in CI. ------ Before Deciding to remove static_build from CI we tried things below : Things decided below worked but in order to keep maintaince simple consensus was made to remove static_build. Read more here: containers#3679 It seems nixos/nix:latest expects nixbld user to be added and specified in build-users-group but this should be only needed for multi-user mode. Hence I suspect latest push has a regression. Lock the nix to last working image. [NO NEW TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@redhat.com>
57ee2fe
to
8de75fd
Compare
nixos/nix
version to last working release i.e 2.3.12
static_build
@containers/podman-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In order to keep CI maintenance simple and not to deal with very frequent
nix
hiccups consensuswas made to remove
static_build
from CI.Read more here: #3679
Before deciding to remove
static_build
we tried things below:It seems nixos/nix:latest expects nixbld user to be added and specified in
build-users-group but this should be only needed for multi-user
mode.
Hence I suspect latest push has a regression. Lock the nix to last working
image.
Following PR fixes regression for artifacts in CI
See: containers/crun#812
And discussion here: #3679 (comment)