-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse: allow parsing anomaly non-human value for memory control group #3679
parse: allow parsing anomaly non-human value for memory control group #3679
Conversation
We use docker helpers to parse human readable value for |
I think buildah |
@cevich @edsantiago I suspect this a |
I'm totally fine with disabling nix, it seems to be a constant source of problems. I think this is how @cevich disabled it in podman: diff --git a/.cirrus.yml b/.cirrus.yml
index 37d102fa..fa064bfe 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -201,6 +201,8 @@ static_build_task:
name: "Static Build"
alias: static_build
only_if: *not_docs
+ # 2021-12-15 nix is dead broken and unmaintained
+ allow_failures: $CI == $CI
depends_on:
- unit
|
LGTM |
That will simply ignore the results. I suggest just nuke the whole task (and remove it from |
Changes LGTM |
@saschagrunert PTAL |
I'm not blocking on removing the static builds. |
Remove `static_build` from ci as it is becoming hard to keep up with `nix` hiccups in CI. ------ Before Deciding to remove static_build from CI we tried things below : Things decided below worked but in order to keep maintaince simple consensus was made to remove static_build. Read more here: containers#3679 It seems nixos/nix:latest expects nixbld user to be added and specified in build-users-group but this should be only needed for multi-user mode. Hence I suspect latest push has a regression. Lock the nix to last working image. [NO NEW TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@redhat.com>
Memory control group accepts an anomaly value of `-1` for setting `swap` to unlimited. Buildah must accepts this value if specified. Reference: https://github.com/opencontainers/runtime-spec/blob/main/config-linux.md#memory Signed-off-by: Aditya Rajan <arajan@redhat.com>
5c6563b
to
9347404
Compare
Rebased after: #3680 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Memory control group accepts an anomaly value of
-1
for settingswap
to unlimited.Buildah must accepts this value if specified.
Reference: https://github.com/opencontainers/runtime-spec/blob/main/config-linux.md#memory
Closes: #3675