Don't overwrite directory permissions on --chown #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch?
|
bertinatto
force-pushed
the
fix-permission
branch
12 times, most recently
from
9bb6e72
to
0ed4720
Compare
|
bot, add author to whitelist |
rhatdan
reviewed
Jan 16, 2018
add.go
Outdated
| return errors.Wrapf(err, "error ensuring directory %q exists", path) | ||
| } | ||
| if err := os.Chown(path, int(user.UID), int(user.GID)); err != nil { | ||
| return errors.Wrapf(err, "error ensuring directory %q exists", path) |
There was a problem hiding this comment.
SHouldn't this be
"error setting ownership of %q"
There was a problem hiding this comment.
Thanks for reviewing!
add.go
Outdated
| @@ -154,14 +154,14 @@ func (b *Builder) Add(destination string, extract bool, options AddAndCopyOption | |||
| // to create it first, so that if there's a problem, | |||
| // we'll discover why that won't work. | |||
| d := dest | |||
| if err := os.MkdirAll(d, 0755); err != nil { | |||
There was a problem hiding this comment.
Nit, should just remove d and use dest everywhere.
Signed-off-by: Fabio Bertinatto <fbertina@redhat.com>
bertinatto
force-pushed
the
fix-permission
branch
from
0ed4720
to
1085598
Compare
|
LGTM |
|
📌 Commit 1085598 has been approved by |
|
☀️ Test successful - status-papr |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR ( #336) I failed to check if my changes were changing the ownership of:
As a result, I'm proposing these changes to fix that.
I'm happy to re-work my patch if you think the approach isn't appropriate.
Thanks.