build, mount: allow realtive mountpoints wrt to work dir for --mount=type=cache and --mount=type=bind
#4452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
force-pushed
the
relative-mount
branch
from
cedba22
to
96c737f
Compare
rhatdan
reviewed
Dec 9, 2022
rhatdan
reviewed
Dec 9, 2022
flouthoc
force-pushed
the
relative-mount
branch
from
96c737f
to
d83c87b
Compare
rhatdan
reviewed
Dec 14, 2022
rhatdan
reviewed
Dec 14, 2022
|
Since filepath.Join automatically does a clean, there is no reason to add one to the code. Remove the clean and this |
When working with `--mount=type=bind` and `--mount=type=cache` allow `target` to accept relative paths w.r.t to the configured work dir. Closes: containers#4309 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
relative-mount
branch
from
d83c87b
to
d9578d3
Compare
|
@containers/buildah-maintainers @nalind PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with
--mount=type=bindand--mount=type=cacheallowtargetto accept relative paths w.r.t to the configured work dir.Closes: #4309