-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build, mount: allow realtive mountpoints wrt to work dir for --mount=type=cache
and --mount=type=bind
#4452
Conversation
cedba22
to
96c737f
Compare
96c737f
to
d83c87b
Compare
Since filepath.Join automatically does a clean, there is no reason to add one to the code. Remove the clean and this |
When working with `--mount=type=bind` and `--mount=type=cache` allow `target` to accept relative paths w.r.t to the configured work dir. Closes: containers#4309 Signed-off-by: Aditya R <arajan@redhat.com>
d83c87b
to
d9578d3
Compare
@containers/buildah-maintainers @nalind PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When working with
--mount=type=bind
and--mount=type=cache
allowtarget
to accept relative paths w.r.t to the configured work dir.Closes: #4309