docs: specify order preference for FROM when using multiple containerfiles
#4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple files are specified buildah considers `FROM` instruction from the last file specified and so does `buildkit` and `docker` so lets specify that in docs. [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Closes: containers#4544 Signed-off-by: Aditya R <arajan@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/lgtm |
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Jan 31, 2023
When multiple files are specified buildah considers `FROM` instruction from the last file specified and so does `buildkit` and `docker` so lets specify that in docs. [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Similar to: containers/buildah#4546 Signed-off-by: Aditya R <arajan@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/podman
that referenced
this pull request
Feb 7, 2023
When multiple files are specified buildah considers `FROM` instruction from the last file specified and so does `buildkit` and `docker` so lets specify that in docs. [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Similar to: containers/buildah#4546 Signed-off-by: Aditya R <arajan@redhat.com>
ashley-cui
pushed a commit
to openshift-cherrypick-robot/podman
that referenced
this pull request
Feb 7, 2023
When multiple files are specified buildah considers `FROM` instruction from the last file specified and so does `buildkit` and `docker` so lets specify that in docs. [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Similar to: containers/buildah#4546 Signed-off-by: Aditya R <arajan@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple files are specified buildah considers
FROMinstruction from the last file specified and so doesbuildkitanddockerso lets specify that in docs.[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
Closes: #4544