Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] docs: specify order preference for FROM #17293

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[CI:DOCS] docs: specify order preference for FROM #17293

merged 1 commit into from
Jan 31, 2023

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Jan 31, 2023 •
edited
Loading

When multiple files are specified buildah considers FROM instruction from the last file specified and so does buildkit and docker so lets specify that in docs.

[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]

Similar to: containers/buildah#4546

docs: specify order preference for FROM

@flouthoc
docs: specify order preference for FROM
2e39712 
When multiple files are specified buildah considers `FROM` instruction
from the last file specified and so does `buildkit` and `docker` so lets
specify that in docs.

[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]

Similar to: containers/buildah#4546

Signed-off-by: Aditya R <arajan@redhat.com>
@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Jan 31, 2023
@flouthoc flouthoc changed the title docs: specify order preference for FROM [CI:DOCS] docs: specify order preference for FROM Jan 31, 2023
@rhatdan
Copy link
Member

rhatdan commented Jan 31, 2023

LGTM
@containers/podman-maintainers PTAL

@rhatdan rhatdan added the 4.4 label Jan 31, 2023
vrothberg
vrothberg approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

/cherry-pick v4.4

@openshift-cherrypick-robot
Copy link
Collaborator

@vrothberg: once the present PR merges, I will cherry-pick it on top of v4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick v4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0488fad into containers:main Jan 31, 2023
@ashley-cui
Copy link
Member

/cherry-pick v4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 7, 2023
Merged
@openshift-cherrypick-robot
Copy link
Collaborator

@ashley-cui: new pull request created: #17408

In response to this:

/cherry-pick v4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg approved these changes

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@flouthoc @rhatdan @vrothberg @openshift-cherrypick-robot @ashley-cui @openshift-merge-robot