[CI:DOCS] Fix tutorial for rootless mode #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/documentation
|
Thanks @Steffen1989 git commit -a --amend -s |
rhatdan
changed the title
Before executing `buildah unshare` for mounting a container from scratch as a non-root user, we need to export the variable `newcontainer` so that it is known inside the modified user namespace. Signed-off-by: Steffen Straub <22006250+Steffen1989@users.noreply.github.com>
Steffen1989
force-pushed
the
fix_tutorial_1
branch
from
4cbfa82
to
0ed9b4c
Compare
|
Sorry about that. I mistook signing the commit "-S" with signing it off "-s" when reading the guide for contributing. |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, Steffen1989 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Before executing
buildah unsharefor mounting a container from scratch as a non-root user, we need to export the variablenewcontainerso that it is known inside the modified user namespace.I was following along this tutorial myself (in rootless mode) and stumbled upon this issue.
I hope this helps the next person to read it.
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?