manifest add: complain if we get artifact flags without --artifact #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhatdan
reviewed
Feb 29, 2024
cmd/buildah/manifest.go
Outdated
| @@ -533,6 +533,11 @@ func manifestAddCmd(c *cobra.Command, args []string, opts manifestAddOpts) error | |||
| return err | |||
| } | |||
| } else { | |||
| for _, artifactOption := range []string{"artifact-type", "artifact-config", "artifact-config-type", "artifact-layer-type", "artifact-subject", "artifact-exclude-titles"} { | |||
| if c.Flags().Changed(artifactOption) { | |||
| return fmt.Errorf("--%s requires --artifact", artifactOption) | |||
There was a problem hiding this comment.
Can we report all of these at once, rather then one at a time?
Complain if `manifest add` is invoked with any of "--artifact-type", "--artifact-config", "--artifact-config-type", "--artifact-layer-type", "--artifact-subject", "--artifact-exclude-titles", but not in conjunction with "--artifact". [NO NEW TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
artifact-cli-flags
branch
from
171ae78
to
8a1bcd5
Compare
|
LGTM |
|
/lgtm |
edsantiago
added
the
No New Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Complain if
manifest addis invoked with any of "--artifact-type", "--artifact-config", "--artifact-config-type", "--artifact-layer-type", "--artifact-subject", "--artifact-exclude-titles", but not in conjunction with "--artifact".How to verify it
Attempt to use one of the "--artifact-type", "--artifact-config", "--artifact-config-type", "--artifact-layer-type", "--artifact-subject", or "--artifact-exclude-titles" flags with
buildah manifest addwithout also specifying "--artifact". It can be an easy thing to overlook, and if your filename happens to look like an image name, the error message you'd have gotten about it could be more confusing.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
I added a check for this in containers/podman#21653, and thought it would be a good idea to add it here, too.
Does this PR introduce a user-facing change?