-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman manifest add: support creating artifact manifest on the fly #21653
podman manifest add: support creating artifact manifest on the fly #21653
Conversation
Ephemeral COPR build failed. @containers/packit-build please check. |
20f2244
to
5d73524
Compare
5d73524
to
4fb821a
Compare
/label bloat_approved |
@nalind: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
117f3a1
to
b16d688
Compare
3487bed
to
10a0b11
Compare
10a0b11
to
35cd59f
Compare
43f9323
to
b1ac0b7
Compare
Cockpit tests failed for commit 35cd59f. @martinpitt, @jelly, @mvollmer please check. |
195f51b
to
909ecc0
Compare
Code LGTM |
LGTM and happy green test buttons on this 5.0 PR. |
/lgtm |
909ecc0
to
7d90bc3
Compare
Reduced the number of flag combinations, added |
7d90bc3
to
d0a583f
Compare
Make sure that env.Join() doesn't modify passed-in maps by cloning them and using only the clones. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Add a --artifact flag to `podman manifest add` which can be used to create an artifact manifest for one or more files and attach it to a manifest list. Corresponding --artifact-type, --artifact-config-type, --artifact-config, --artifact-layer-type, --artifact-subject, and --artifact-exclude-titles options can be used to fine-tune the fields in the artifact manifest that don't refer to the files themselves. Add a --index option to `podman manifest annotate` that will cause values passed to the --annotation flag to be applied to the manifest list as a whole instead of to an entry in the list. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
d0a583f
to
f168b3c
Compare
/lgtm |
@nalind now you have red tests kicking up their heels. |
Give it a minute. Also needs a "/approve" from someone listed as an approver in the OWNERS file. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add a
--artifact
flag topodman manifest add
which can be used to create an artifact manifest for one or more files and attach it to a manifest list. Corresponding--artifact-type
,--artifact-config-type
,--artifact-config
,--artifact-layer-type
,--artifact-subject
, and--artifact-exclude-titles
flags can be used to fine-tune the fields in the artifact manifest that don't refer to the files themselves.Add
--index
and--subject
flags topodman manifest annotate
that will cause values passed to the--annotation
flag to be applied to the manifest list as a whole instead of to an entry in the list, and which will add a reference to the manifest for the--subject
argument.Add a
--annotation
flag topodman manifest create
that will cause annotations to be added to the new image index, which has the side-effect of forcing its format to be OCI from the start.Does this PR introduce a user-facing change?