Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman manifest add: support creating artifact manifest on the fly #21653

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

nalind
Copy link
Member

@nalind nalind commented Feb 14, 2024

Add a --artifact flag to podman manifest add which can be used to create an artifact manifest for one or more files and attach it to a manifest list. Corresponding --artifact-type, --artifact-config-type, --artifact-config, --artifact-layer-type, --artifact-subject, and --artifact-exclude-titles flags can be used to fine-tune the fields in the artifact manifest that don't refer to the files themselves.

Add --index and --subject flags to podman manifest annotate that will cause values passed to the --annotation flag to be applied to the manifest list as a whole instead of to an entry in the list, and which will add a reference to the manifest for the --subject argument.

Add a --annotation flag to podman manifest create that will cause annotations to be added to the new image index, which has the side-effect of forcing its format to be OCI from the start.

Does this PR introduce a user-facing change?

`podman manifest add` now supports `--artifact` and related flags which will create an artifact manifest for one or more files and add them to the specified manifest list.

@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 14, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Feb 14, 2024
@nalind
Copy link
Member Author

nalind commented Feb 15, 2024

/label bloat_approved

Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

@nalind: The label(s) /label bloat_approved cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label bloat_approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nalind nalind added the bloat_approved Approve a PR in which binary file size grows by over 50k label Feb 15, 2024
@nalind nalind force-pushed the fun-with-artifacts branch 3 times, most recently from 117f3a1 to b16d688 Compare February 15, 2024 15:23
@rhatdan
Copy link
Member

rhatdan commented Feb 15, 2024

@nalind nalind force-pushed the fun-with-artifacts branch 2 times, most recently from 3487bed to 10a0b11 Compare February 15, 2024 20:19
@baude baude added the 5.0 label Feb 20, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@nalind nalind force-pushed the fun-with-artifacts branch 2 times, most recently from 43f9323 to b1ac0b7 Compare February 27, 2024 21:23
Copy link

Cockpit tests failed for commit 35cd59f. @martinpitt, @jelly, @mvollmer please check.

@nalind nalind force-pushed the fun-with-artifacts branch 2 times, most recently from 195f51b to 909ecc0 Compare February 28, 2024 15:45
@nalind nalind marked this pull request as ready for review February 28, 2024 17:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024
@mheon
Copy link
Member

mheon commented Feb 28, 2024

Code LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM and happy green test buttons on this 5.0 PR.

@rhatdan
Copy link
Member

rhatdan commented Feb 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@nalind
Copy link
Member Author

nalind commented Feb 28, 2024

Reduced the number of flag combinations, added --artifact-config to the flags tested, and added a cleanup of the test-specific registry to the "manifest list --add --artifact" test.

nalind and others added 3 commits February 29, 2024 11:47
Make sure that env.Join() doesn't modify passed-in maps by cloning them
and using only the clones.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Add a --artifact flag to `podman manifest add` which can be used to
create an artifact manifest for one or more files and attach it to a
manifest list.  Corresponding --artifact-type, --artifact-config-type,
--artifact-config, --artifact-layer-type, --artifact-subject, and
--artifact-exclude-titles options can be used to fine-tune the fields in
the artifact manifest that don't refer to the files themselves.

Add a --index option to `podman manifest annotate` that will cause
values passed to the --annotation flag to be applied to the manifest
list as a whole instead of to an entry in the list.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Feb 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@TomSweeneyRedHat
Copy link
Member

@nalind now you have red tests kicking up their heels.

@nalind
Copy link
Member Author

nalind commented Feb 29, 2024

Give it a minute. Also needs a "/approve" from someone listed as an approver in the OWNERS file.

@mheon
Copy link
Member

mheon commented Feb 29, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b681209 into containers:main Feb 29, 2024
94 checks passed
@nalind nalind deleted the fun-with-artifacts branch February 29, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants