tests: enable pasta tests #5381
Conversation
|
LGTM. Cirrus VMs are |
|
LGTM |
|
/lgtm |
|
@TomSweeneyRedHat Note, there was no conflict nor any real changes of causing other merge problems here. The rebase feature creates completely useless merge commits in the git log by default, ("Merge branch 'main' into pasta") is obviously not useful when reading the git log. If you really want to make sure everything is up to date even when there is no need then please make sure to rebase the PR and not use a merge commit: |
This should have been done a long time ago and this would have made clear that it did not work properly. However now that pasta is the default and we fixed all the remaining problems we can easily enable them. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
@Luap99, apologies for the merge hiccups. I just saw what looked to be a "You can' merge this unless you hit this big shiny button", and since it was late, I hit the shiny. I'll try to pay more attention going forward. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind other
What this PR does / why we need it:
This should have been done a long time ago and this would have made clear that it did not work properly. However now that pasta is the default and we fixed all the remaining problems we can easily enable them.
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?