Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-push: add support for --digestfile #5454

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Apr 2, 2024

Allow writing digest of the pushed source to the specified digestfile

Closes: #5399

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

source-push: add support for --digestfile

Closes: #5399

@nalind
Copy link
Member

nalind commented Apr 2, 2024

I don't really want to go very far down the road of reimplementing every push option for buildah source push.

@flouthoc
Copy link
Collaborator Author

flouthoc commented Apr 2, 2024

I don't really want to go very far down the road of reimplementing every push option for buildah source push.

@nalind Ah I agree, I was wondering if there any other workaround to original #5399 , i was unable to find one and adding a --digestfile looked quick and reasonable so i did this change, although I agree we can't re-implementing all flags here. I'm with fine closing this PR.

Copy link

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me

@@ -20,6 +20,10 @@ The [username[:password]] to use to authenticate with the registry if required.
If one or both values are not supplied, a command line prompt will appear and the
value can be entered. The password is entered without echo.

**--digestfile** *Digestfile*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not a new thing but why is Digestfile capitalized? It's not a well known thing like Dockerfile...)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, I think it got copied from older man-page, will fix it up there as well.

Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 2, 2024
Allow writing digest of the pushed source to the specified `digestfile`

Closes: containers#5399

Signed-off-by: flouthoc <flouthoc.git@gmail.com>
@rhatdan
Copy link
Member

rhatdan commented Apr 3, 2024

/lgtm
/hold

@rhatdan
Copy link
Member

rhatdan commented Apr 3, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit dc99fbe into containers:main Apr 3, 2024
36 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --digestfile support to buildah source push
4 participants