Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: drop override for github.com/opencontainers/runc #1633

Closed
wants to merge 1 commit into from
Closed

vendor: drop override for github.com/opencontainers/runc #1633

wants to merge 1 commit into from

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Sep 1, 2023

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 1, 2023
@giuseppe giuseppe marked this pull request as draft September 1, 2023 12:47
@giuseppe giuseppe force-pushed the drop-runc-override branch 2 times, most recently from 2e30b1f to 9b08dc6 Compare September 1, 2023 13:01
@giuseppe
Copy link
Member Author

giuseppe commented Sep 1, 2023

opened a PR for runc: opencontainers/runc#4005

@vrothberg
Copy link
Member

vrothberg commented Sep 4, 2023 •
edited
Loading

Build fails. I think we need to bundle that with a Podman test PR to make sure everything's OK

 ?   	github.com/containers/common/pkg/apparmor	[no test files]
# github.com/containers/common/pkg/cgroups [github.com/containers/common/pkg/cgroups.test]
pkg/cgroups/cgroups_linux_test.go:50:3: unknown field BlockIODevice in struct literal of type configs.ThrottleDevice
pkg/cgroups/cgroups_linux_test.go:50:26: undefined: configs.BlockIODevice
pkg/cgroups/cgroups_linux_test.go:57:3: unknown field BlockIODevice in struct literal of type configs.ThrottleDevice
pkg/cgroups/cgroups_linux_test.go:57:26: undefined: configs.BlockIODevice
pkg/cgroups/cgroups_linux_test.go:64:3: unknown field BlockIODevice in struct literal of type configs.WeightDevice
pkg/cgroups/cgroups_linux_test.go:64:26: undefined: configs.BlockIODevice

@rhatdan
Copy link
Member

rhatdan commented Nov 2, 2023

Looks like this one succeeded. Ready to Merge?
LGTM

@giuseppe giuseppe marked this pull request as ready for review November 2, 2023 22:31
@giuseppe
vendor: drop replace for github.com/opencontainers/runc
a62c893 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
Copy link
Member Author

giuseppe commented Nov 2, 2023

I'll open a test PR for Podman as soon as containers/podman#20568 merges

@giuseppe
Copy link
Member Author

giuseppe commented Nov 2, 2023

test PR: containers/podman#19817

@giuseppe giuseppe mentioned this pull request Nov 2, 2023
Closed
@giuseppe
Copy link
Member Author

giuseppe commented Nov 3, 2023

runc is still bloated: containers/podman#19817

I've reported the issue (opencontainers/runc#4005). Closing this PR for now as I don't see a way to avoid the extra 1M bloat from eBPF:

@giuseppe giuseppe closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giuseppe @vrothberg @rhatdan @openshift-merge-robot