pkg/config: remove deprecated MachineEnabled field #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We now only use the marker file, see pkg/machine. The advantage of this is that pkg/machine no longer imports pkg/config and we use it in rootlessport which means it will debloat the binary there significantly. The file approach has been added in podman 4.1 (2 years ago) so basically all machines should have it now and this shouldn't break anything. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
force-pushed
the
machine-enabled
branch
from
44878e0
to
3f60883
Compare
|
LGTM |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now only use the marker file, see pkg/machine.
The advantage of this is that pkg/machine no longer imports pkg/config and we use it in rootlessport which means it will debloat the binary there significantly.
The file approach has been added in podman 4.1 (2 years ago) so basically all machines should have it now and this shouldn't break anything.