Move ignition functions into Containerfiles #21778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
baude
force-pushed
the
removeignition
branch
from
3ef4f85
to
a90ae24
Compare
|
LGTM |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Luap99
reviewed
Feb 22, 2024
openshift-merge-robot
added
the
needs-rebase
baude
force-pushed
the
removeignition
branch
from
a90ae24
to
f2c48d6
Compare
openshift-merge-robot
removed
the
needs-rebase
baude
force-pushed
the
removeignition
branch
from
f2c48d6
to
9d9d4e4
Compare
|
depends on #21765 |
baude
force-pushed
the
removeignition
branch
from
9d9d4e4
to
942705d
Compare
|
LGTM |
baude
force-pushed
the
removeignition
branch
2 times, most recently
from
eaf2c34
to
845acda
Compare
|
Should this have a 5.0 label? |
baude
force-pushed
the
removeignition
branch
from
845acda
to
a0ecce0
Compare
Luap99
reviewed
Feb 28, 2024
baude
force-pushed
the
removeignition
branch
3 times, most recently
from
c6d726f
to
d8749ae
Compare
cevich
reviewed
Feb 28, 2024
baude
force-pushed
the
removeignition
branch
from
d8749ae
to
6df0093
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
baude
force-pushed
the
removeignition
branch
from
6df0093
to
4ae0080
Compare
|
Should this have a 5.0 label? |
|
Nevermind it does, I need coffee |
|
Code LGTM |
|
/lgtm |
baude
force-pushed
the
removeignition
branch
from
4ae0080
to
3f3531b
Compare
We used to use ignition to perform any customization required for podman machine because our input was a generic FCOS image. Now that we are building our own images, some of this customization can be migrated to the Containerfile itself and be less of a burden in our code at boot up. At the time of this PR, the Containerfile can be found at https://github.com/baude/podman-machine-images/tree/main. It is only present for a so-called daily image. There is little liklihood that this would the final location for the Containerfile so consider it a working version only. Split WSL and rest apart in the e2e tests so we no longer ppull the generic FCOS image for testing. Note: the change to the pull image name is so PRs are not immediately broken that are already in the queue. [NO NEW TESTS REQUIRED] Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
force-pushed
the
removeignition
branch
from
3f3531b
to
fd1d951
Compare
|
Cockpit tests failed for commit fd1d951. @martinpitt, @jelly, @mvollmer please check. |
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 12b8cc8
into
containers:main
92 of 93 checks passed
This was referenced Feb 29, 2024
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to use ignition to perform any customization required for podman machine because our input was a generic FCOS image. Now that we are building our own images, some of this customization can be migrated to the Containerfile itself and be less of a burden in our code at boot up.
At the time of this PR, the Containerfile can be found at https://github.com/baude/podman-machine-images/tree/main. It is only present for a so-called daily image. There is little liklihood that this would the final location for the Containerfile so consider it a working version only.
Note: the change to the pull image name is so PRs are not immediately broken that are already in the queue.
[NO NEW TESTS REQUIRED]
Does this PR introduce a user-facing change?