-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ignition functions into Containerfiles #21778
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3ef4f85
to
a90ae24
Compare
LGTM |
a90ae24
to
f2c48d6
Compare
f2c48d6
to
9d9d4e4
Compare
depends on #21765 |
9d9d4e4
to
942705d
Compare
LGTM |
eaf2c34
to
845acda
Compare
Should this have a 5.0 label? |
845acda
to
a0ecce0
Compare
c6d726f
to
d8749ae
Compare
d8749ae
to
6df0093
Compare
6df0093
to
4ae0080
Compare
Should this have a 5.0 label? |
Nevermind it does, I need coffee |
Code LGTM |
/lgtm |
4ae0080
to
3f3531b
Compare
We used to use ignition to perform any customization required for podman machine because our input was a generic FCOS image. Now that we are building our own images, some of this customization can be migrated to the Containerfile itself and be less of a burden in our code at boot up. At the time of this PR, the Containerfile can be found at https://github.com/baude/podman-machine-images/tree/main. It is only present for a so-called daily image. There is little liklihood that this would the final location for the Containerfile so consider it a working version only. Split WSL and rest apart in the e2e tests so we no longer ppull the generic FCOS image for testing. Note: the change to the pull image name is so PRs are not immediately broken that are already in the queue. [NO NEW TESTS REQUIRED] Signed-off-by: Brent Baude <bbaude@redhat.com>
3f3531b
to
fd1d951
Compare
Cockpit tests failed for commit fd1d951. @martinpitt, @jelly, @mvollmer please check. |
LGTM |
/lgtm |
/hold cancel |
12b8cc8
into
containers:main
We used to use ignition to perform any customization required for podman machine because our input was a generic FCOS image. Now that we are building our own images, some of this customization can be migrated to the Containerfile itself and be less of a burden in our code at boot up.
At the time of this PR, the Containerfile can be found at https://github.com/baude/podman-machine-images/tree/main. It is only present for a so-called daily image. There is little liklihood that this would the final location for the Containerfile so consider it a working version only.
Note: the change to the pull image name is so PRs are not immediately broken that are already in the queue.
[NO NEW TESTS REQUIRED]
Does this PR introduce a user-facing change?