Add negation to filters

[rvandernoort]

This PR closes this issue, which adds a negation option to all filters for the podman images --filter command. I tested this locally by building an image with a label of version:0.1 and running bin/podman images --filter 'label=version=0.1' gives me only this image listed and running bin/podman images --filter 'label!=version=0.1' gives me all other images listed. I also tested the other filter options, and they all have the same effect!

Signed-off-by: rvandernoort s.r.vandernoort@student.tudelft.nl

[vrothberg]

Thanks! Could you add a couple of tests to libimage/filters_test.go to make sure it's working as expected and that we won't regress in the future?

[rvandernoort]

Yeah of course, but I was thinking about it, is there any image that has like a testable label I could use for it? Because as an example, build-testimage only has these two labels, which are not really great for it.

LABEL created_by=$create_script
LABEL created_at=$create_time_z

[rhatdan]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, rvandernoort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

LGTM

[rhatdan]

@vrothberg @giuseppe PTAL

[vrothberg]

Code LGTM but we need tests.

[rvandernoort]

@vrothberg I created a test for it now locally, but as I stated I need a testimage with a label, which I couldn't find. I created a simple Dockerfile for it now, can I upload this or something similar somewhere in the lipbod registry on quay to retrieve it in the test?

FROM alpine:latest

LABEL test=1

RUN apk update && \
    apk add git

ENTRYPOINT ["git"]
CMD ["--help"]

[vrothberg]

@rvandernoort, there are other filters that we can (and should) use for testing.

For testing the label filter, you could use the following one:

~ $ skopeo inspect docker://quay.io/libpod/alpine_labels
{
    "Name": "quay.io/libpod/alpine_labels",
    "Digest": "sha256:30358dabe30a2e61968ad5b1deb1b8a988affb9db6e0c0efd6bad214d6c33284",
    "RepoTags": [
        "master",
        "latest"
    ],
    "Created": "2022-02-14T19:00:12.512223338Z",
    "DockerVersion": "20.10.6",
    "Labels": {
        "PODMAN": "/usr/bin/podman run -it --name NAME -e NAME=NAME -e IMAGE=IMAGE IMAGE echo podman",
        "install": "docker run -it --name NAME -e NAME=NAME -e IMAGE=IMAGE IMAGE echo install",
        "options": "/usr/bin/podman run -it --name NAME -e NAME=NAME -e IMAGE=IMAGE IMAGE echo $OPT1 ",
        "run": "docker run -it --name NAME -e NAME=NAME -e IMAGE=IMAGE IMAGE echo RUN",
        "uninstall": "/usr/bin/docker run -it --name NAME -e NAME=NAME -e IMAGE=IMAGE IMAGE echo uninstall",
        "useradds": "/usr/bin/docker run -it IMAGE echo"
    },
    "Architecture": "amd64",
    "Os": "linux",
    "Layers": [
        "sha256:59bf1c3509f33515622619af21ed55bbe26d24913cedbca106468a5fb37a50c3"
    ],
    "Env": [
        "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
    ]
}

[rvandernoort]

Yes perfect thank you! I've pushed the first test with the label filter, I'll make the remainder of the tests for the different filters soon.

[rvandernoort]

Alright so I updated the test suite to cover more labels with and without negation. I did get stuck with running a container inside the unit tests here for the specific images in order to test the containers, dangling, intermediate, and readonly filter, any suggestions on how I should do this, because I could not find any example in the tests so far.

[vrothberg]

Thanks a lot, @rvandernoort! Just one minor nit and then we can merge.

[vrothberg]

/lgtm
/hold
Thank you!

[vrothberg]

/hold cancel