Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor c/common for filters #13611

Merged
merged 1 commit into from Mar 27, 2022
Merged

Vendor c/common for filters #13611

merged 1 commit into from Mar 27, 2022

Conversation

rvandernoort
Copy link
Contributor

@rvandernoort rvandernoort commented Mar 23, 2022 •
edited

Vendor common to introduce the filters from PR containers/common#971 such that we can mege the docs update in PR #13607 originally from issue #13270.

Signed-off-by: rvandernoort s.r.vandernoort@student.tudelft.nl

vrothberg
vrothberg approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that you could have also added another commit to #13607 which would vendor c/common.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rvandernoort, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@rvandernoort
Copy link
Contributor Author

Ah yes ofc I could have also done that and changed the title i guess, but I thought this needed a CI check so therefore I created a new PR.

@rvandernoort
Copy link
Contributor Author

@rhatdan I think some of the tests are failing here, because I also vendored in this commit containers/common@83015b5 . Do you know how we can fix this?

@rhatdan
Copy link
Member

rhatdan commented Mar 25, 2022 •
edited

Add this patch
0002-Add-support-for-Sharable.patch

@rvandernoort
Copy link
Contributor Author

Unfortuately the link seems to direct me to this PR's page?

@rhatdan
Copy link
Member

rhatdan commented Mar 25, 2022

@rvandernoort Fixed.

@TomSweeneyRedHat
Copy link
Member

Changes LGTM, test do not

@rvandernoort
Copy link
Contributor Author

@rhatdan I applied the patch. But do we need tests for the changes or should I add no tests needed to the commit msg?

@rvandernoort
Vendor common
446c35e 
Added patch provided by rhatdan to add support for shareable

[NO NEW TESTS NEEDED]

Signed-off-by: rvandernoort <s.r.vandernoort@student.tudelft.nl>
@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2022

/lgtm
/hold
@rvandernoort This looks good.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0ebf0bc into containers:main Mar 27, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rvandernoort @rhatdan @TomSweeneyRedHat @vrothberg @openshift-merge-robot