WIP: conn_sock: close stdout side when we don't close stdin #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the main consumer of leave-stdin-open, cri-o, needs stdin to stay open, but also wants to consume all data from stdout. It does not know when the output from stdout has ended unless conmon closes its side of the pipe. the problem is, if we don't close masterfd_stdin, we also don't close masterfd_stdout, as they point to the same side pipe, which results in cri-o sitting and waiting for input forever. instead, we need to close the stdout side of the pipe if we don't close masterfd_stdin Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
changed the title
|
waiting on cri-o/cri-o#3787 to verify no breaking changes here (the test passed but I didn't test any others) |
|
cri-o/cri-o#3812 fixes the tests. We don't need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the main consumer of leave-stdin-open, cri-o, needs stdin to stay open, but also wants to consume all data from stdout.
It does not know when the output from stdout has ended unless conmon closes its side of the pipe.
the problem is, if we don't close masterfd_stdin, we also don't close masterfd_stdout, as they point to the same side pipe, which results in cri-o sitting and waiting for input forever.
instead, we need to close the stdout side of the pipe if we don't close masterfd_stdin
Signed-off-by: Peter Hunt pehunt@redhat.com