oci: Don't return early for non-tty attach if there is no stdin #3812
Conversation
We want to return early from a non-tty attach only if stdin is enabled otherwise we want to wait for the output as well. Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
openshift-ci-robot
added
the
dco-signoff: yes
openshift-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #3812 +/- ##
=======================================
Coverage 40.18% 40.18%
=======================================
Files 105 105
Lines 8692 8692
=======================================
Hits 3493 3493
Misses 4888 4888
Partials 311 311 |
|
@haircommander @saschagrunert @giuseppe ptal. This fixes the tests. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
woho green tests! I am fine to merge it but I still don't understand this requirement, why should we ignore stdout on |
|
it seems to be docker behavior. All of this is pretty poorly documented. Unfortunately, if a dockershim test passes and we fail, then we have to go to that :\ /lgtm |
|
/cherry-pick release-1.18 |
|
@haircommander: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cri-o\n ! [remote rejected] cherry-pick-3812-to-release-1.18 -> cherry-pick-3812-to-release-1.18 (cannot lock ref 'refs/heads/cherry-pick-3812-to-release-1.18': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/cri-o'\n", error: exit status 1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@haircommander: new pull request created: #3813 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We want to return early from a non-tty attach only if stdin is
enabled otherwise we want to wait for the output as well.
Signed-off-by: Mrunal Patel mrunalp@gmail.com
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This PR fixes a race exposed by recent changes in kubernetes/kubernetes#91227
Does this PR introduce a user-facing change?